Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor ManagedStorage for save get #727

Merged
merged 1 commit into from
Aug 23, 2021
Merged

refactor ManagedStorage for save get #727

merged 1 commit into from
Aug 23, 2021

Conversation

Sneezry
Copy link
Member

@Sneezry Sneezry commented Aug 21, 2021

The hard coded ManagedStorage.get default value false doesn't make sense. We also have keys with string values, and their default values should not be false.

@Sneezry Sneezry requested a review from mymindstorm August 21, 2021 20:13
@codecov
Copy link

codecov bot commented Aug 21, 2021

Codecov Report

Merging #727 (4854efb) into dev (8c9beba) will not change coverage.
The diff coverage is 92.30%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #727   +/-   ##
=======================================
  Coverage   18.45%   18.45%           
=======================================
  Files          17       17           
  Lines        1523     1523           
  Branches      331      331           
=======================================
  Hits          281      281           
  Misses       1210     1210           
  Partials       32       32           
Impacted Files Coverage Δ
src/models/storage.ts 21.81% <80.00%> (ø)
src/store/Menu.ts 50.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c9beba...4854efb. Read the comment docs.

@Sneezry Sneezry merged commit 5ed548b into dev Aug 23, 2021
@Sneezry Sneezry deleted the save-get branch August 23, 2021 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants