-
Notifications
You must be signed in to change notification settings - Fork 820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add key binding to copy code #691
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #691 +/- ##
==========================================
- Coverage 15.09% 15.07% -0.03%
==========================================
Files 15 15
Lines 1457 1459 +2
Branches 320 320
==========================================
Hits 220 220
- Misses 1219 1221 +2
Partials 18 18
Continue to review full report at Codecov.
|
src/components/Popup/MainBody.vue
Outdated
return entry === firstEntry ? 0 : -1; | ||
}, | ||
findNextEntryIndex( | ||
entries: OTPEntry[], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On all functions, entries, shouldFilter, and filter are all computed properties and don't need to be passed as arguments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated.
I really like this! Bugs / Other:
|
Fixed. After applying password, the first entry will be auto focused.
Entry will have focus when it is clicked. If you click anywhere else, the entry should not have focus. And is as designed.
I don't think so. By following w3 accessibility guide,
Yes. This is a bug in previous commit. I have fixed that in the recent commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great
@@ -14,6 +14,7 @@ | |||
v-model="searchText" | |||
v-bind:placeholder="i18n.search" | |||
type="text" | |||
tabindex="-1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be able to be tabbed to, but it is ok to not allow it until we get around to overhaling keyboard nav for the header and menu. Hopefully compoentizing everything will help at the second version of that.
Will this supersede #689? |
I suppose. Number keys could be hard to use to copy a specific entry. Imaging how to copy the 7th entry in the list. I have to count entries from top to bottom. |
Press arrow keys to select a code, press
enter
to copy.