Onedrive Business account permissions fix #633

[mymindstorm]

No description provided.

[codecov]

Codecov Report

Merging #641 (5db12c3) into dev (63f25ac) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head 5db12c3 differs from pull request most recent head e3f7cdf. Consider uploading reports for the commit e3f7cdf to get more accurate results

@@            Coverage Diff             @@
##              dev     #641      +/-   ##
==========================================
- Coverage   15.15%   15.14%   -0.02%     
==========================================
  Files          15       15              
  Lines        1452     1453       +1     
  Branches      317      318       +1     
==========================================
  Hits          220      220              
- Misses       1214     1215       +1     
  Partials       18       18              

Impacted Files	Coverage Δ
src/models/backup.ts	5.27% <0.00%> (-0.02%)	⬇️
src/store/Backup.ts	18.18% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63f25ac...e3f7cdf. Read the comment docs.

[jbostoen]

Thank you very very much for integrating this!

Should there be a note about permissions to the organization's administrators? Or perhaps to the user telling them they might need to consult their admin?

[mymindstorm]

Should there be a note about permissions to the organization's administrators?

Added

Or perhaps to the user telling them they might need to consult their admin?

The consent screen will prompt users to request admin approval if they cannot authorize the app. At some point in the future, the consent screen will mark the integration as "untrustworthy" due us not being able to register it with a verified publisher (no legal entity to register as a MS Partner with).

[jbostoen]

Any idea when this will result in a new release? 😁

[mymindstorm]

See #646

[Sneezry]

Any idea when this will result in a new release? 😁

For Chrome, because we have more than 1.5M users, we need incremental rollouts. It could be as long as one month to deliver this version to all existing users. New-install users are able to install this version once it's available in CWS. This version should be available in CWS within one week.

For Firefox, @mymindstorm correct me if I have any mistake, it should be already available to all users, including existing users and new-install users.

For Edge, we may need some time before it is available to public, but it could not be too long.

[jbostoen]

Thanks @Sneezry !

Question: is the 'manual sync' actually a one way backup rather than a sync?

I set up the Authenticator with a OneDrive Business on 2 different computers.
They both already had different TOTPs; in the JSON file on OneDrive Business I only see a backup of one of those 2 lists at a time.

[mymindstorm]

For Firefox, @mymindstorm correct me if I have any mistake, it should be already available to all users, including existing users and new-install users.

It is usually immediately available. They used to have incremental rollouts but removed it for some reason.

For Edge, we may need some time before it is available to public, but it could not be too long.

Edge usually takes a week or two for certification and is available immediately.

Question: is the 'manual sync' actually a one way backup rather than a sync

We will have to correct the string. It is a one way backup and is referenced that way in all other parts of the ui. The only "sync" is the browsers built in extension data sync. I would be wary of using it without backups because it tends to be finicky.

[jbostoen]

Hm, thanks for the answer @mymindstorm . I'll have to discuss it with colleagues, but it it would be more clear to remove the word "sync" as it implies two-way sync