update about page #488
Merged
update about page #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mymindstorm
force-pushed
the
licenses-page
branch
from
2c788ae to
e423083
Compare
Sneezry
requested changes
May 22, 2020
Comment on lines
+62
to
+66
| echo "Generating licenses file..." | ||
| ./node_modules/.bin/npm-license-generator \ | ||
| --out-path ./view/licenses.html \ | ||
| --template ./scripts/licenses-template.html \ | ||
| --error-missing=true |
There was a problem hiding this comment.
--registry should be a requied parameter right?
There was a problem hiding this comment.
also, I get URL is not defined error from Authenticator/node_modules/npm-license-generator/build/index.js:100:21
There was a problem hiding this comment.
registry is optional and defaults to registry.npmjs.com. What version of node are you using?
There was a problem hiding this comment.
It's Node 8. I'm upgrading to 12 to test again.
There was a problem hiding this comment.
URL was considered experimental in node 8, I need to add an import for it.
There was a problem hiding this comment.
I have verified on Node 12, no errors in build.
There was a problem hiding this comment.
node 8 is supported with 1.0.1
Sneezry
approved these changes
May 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.