Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ask for local file access permission #173

Merged
merged 1 commit into from
Jul 27, 2018
Merged

ask for local file access permission #173

merged 1 commit into from
Jul 27, 2018

Conversation

Sneezry
Copy link
Member

@Sneezry Sneezry commented Jul 27, 2018

If the user opens a QR image from local file, the extension cannot scan it because we had removed content script permission.

file://*/* permission is disabled by default event if we request it in manifest, and the user needs enable it manually (https://stackoverflow.com/a/19493206/2956469). So this change doesn't expand permission scope.

This change adds local file access section in Chrome extension dashboard:

snipaste20180727_162242

@Sneezry Sneezry requested a review from mymindstorm July 27, 2018 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants