Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Multi dose grids test #165

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

fahimirfanalam
Copy link

Hi @dalmouiee
First version of the notebook to address multi dose-grids is attached for your review.
Thanks.

@fahimirfanalam fahimirfanalam requested a review from dalmouiee May 16, 2024 00:51
@fahimirfanalam fahimirfanalam self-assigned this May 16, 2024
@dalmouiee dalmouiee changed the title Multi dose grids test WIP: Multi dose grids test May 16, 2024
@pchlap
Copy link
Contributor

pchlap commented May 20, 2024

Hi @fahimirfanalam, @dalmouiee, thanks a lot for working on this.

One thing I noticed here is that the sample data is stored within the git repository. To keep the size of the git repo manageable, please store the data as a zip file on Zenodo and have the example scripts pull from there. You can update the fetch_converted_test_data to do this:

def fetch_converted_test_data(

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants