Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add G6-G9 keys and Nameplate to OpenRGBKeyNames. #75

Merged
merged 1 commit into from
Sep 6, 2022
Merged

Add G6-G9 keys and Nameplate to OpenRGBKeyNames. #75

merged 1 commit into from
Sep 6, 2022

Conversation

wfowler1
Copy link

@wfowler1 wfowler1 commented Sep 6, 2022

List any issues that this PR fixes: fixes # , etc...

Fixes #72

This pull request proposes the following changes:

  • Maps G6-G9 keys in OpenRGB to the G6-G9 keys in the DeviceKeys enum.
  • Maps "Nameplate" to "LOGO2". This is the LED for the "G910" logo on the Logitech G910 keyboard. This matches the "BADGE" LED defined in logitech_g910_left_bottom_features.json.

@wfowler1 wfowler1 marked this pull request as ready for review September 6, 2022 10:14
@Aytackydln Aytackydln self-requested a review September 6, 2022 15:50
@Aytackydln Aytackydln merged commit fadc77b into Aurora-RGB:dev Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aytackydln Aytackydln Awaiting requested review from Aytackydln

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wfowler1 @Aytackydln