Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There seem to be another issue with name conflicts #3

Closed
Obi-Dann opened this issue Jun 20, 2019 · 0 comments · Fixed by #4
Closed

There seem to be another issue with name conflicts #3

Obi-Dann opened this issue Jun 20, 2019 · 0 comments · Fixed by #4

Comments

@Obi-Dann
Copy link
Collaborator

Btw, there seem to be another issue with name conflicts:

import { someFunc } from './someFile';

class SomeClass {
  @transformToMobxFlow
  someFunc = async () => {
    await someFunc();
  }
}

This code will run fine without @transformToMobxFlow. When adding it, after it is transformed, the inner call await someFunc() will reference the transformed function, and not the imported one. Is there a way to resolve this? I know it's bad practice to have conflicting names, but these are different scopes and this can happen.

Originally posted by @Tsury in mobxjs/mobx#1410 (comment)

Obi-Dann added a commit that referenced this issue Jun 20, 2019
…UniqueNames_#3

Ensure wrapped generator functions use unique names #3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant