Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor api calls #32

Merged
merged 3 commits into from
Dec 29, 2019
Merged

Refactor api calls #32

merged 3 commits into from
Dec 29, 2019

Conversation

AumitLeon
Copy link
Owner

@AumitLeon AumitLeon commented Dec 29, 2019

Resolves #31. Mocking API calls using jest-fetch-mock: https://www.npmjs.com/package/jest-fetch-mock

Includes a fix for an error where the Box component was failing on an attach type error. @material-ui/[email protected] was released recently and so was JSS 10.0.1. Setting the jss resolver to 10.0.0 and @material-ui/core@^4.8.1, solved the issue.

Watch: mui/material-ui#19005, cssinjs/jss#1249

@codecov
Copy link

codecov bot commented Dec 29, 2019

Codecov Report

Merging #32 into master will increase coverage by 11.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #32       +/-   ##
===========================================
+ Coverage   84.93%   95.94%   +11.01%     
===========================================
  Files           6        7        +1     
  Lines          73       74        +1     
  Branches        7        7               
===========================================
+ Hits           62       71        +9     
+ Misses         11        3        -8
Impacted Files Coverage Δ
client/src/components/UploadDiaglog.js 100% <ø> (+53.33%) ⬆️
client/src/apiCalls.js 100% <100%> (ø)
client/src/setupTests.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff3d8f4...a716152. Read the comment docs.

@AumitLeon AumitLeon merged commit b73babd into master Dec 29, 2019
@AumitLeon AumitLeon deleted the refactor-api-calls branch December 29, 2019 01:11
@AumitLeon
Copy link
Owner Author

🎉 This PR is included in version 1.5.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mock client side fetch calls
1 participant