Symbiotes! #10726
Open
Symbiotes! #10726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
show dash if no liquidity
make breakdown lighter color when inputs are unedited
fix sidebar's bottom bar on mobile
…-and-tables Fixed overflow for network mistmatch, market cards. Fixed table header height
…e preserved between long inputs and the label of the value, also added ellipsis to the text after you lose foccus for really long values.
#10592) * mis math on setting value for activity and transactions for eth add liquidity * fix issue where using same property for two different values
Edge smoothing
…the currency of the exchange.
fix-double-claim-activity
add Kovan for walletConnect
add shimmer to market cards
call new middleware multi-claim for individual market claim winnings
…. prevents a buffer override app blowing up style error (#10599)
…entionally shortening the input display.
fix-bad-input
fix bug where markets weren't updating when liquidity setting was cha…
Support easily paging through logs in base graphql schema
…ghlight.js-10.4.1 Bump highlight.js from 9.15.10 to 10.4.1
…ontents, cleaned/re-installed. dropped old url-loader from package.json top level
remove-comps-start
another-try
|
@Mergifyio rebase dev |
|
Command
|
packages/augur-core/src/contracts/symbiote/SymbioteHatchery.sol
Outdated
Show resolved
Hide resolved
packages/augur-core/src/contracts/symbiote/SymbioteHatchery.sol
Outdated
Show resolved
Hide resolved
| return _config; | ||
| } | ||
|
|
||
| function getSymbioteResolution(uint256 _id) public returns (uint256[] memory) { |
There was a problem hiding this comment.
Maybe call this pullSymbioteResolution? It looks like a getter now but clearly isn't.
|
My understand of this code isn't very deep but from a shallow review, it looks good to me. |
| require(_config.prices.length == 2); | ||
| require(_config.prices[0] < _config.prices[1]); | ||
| require(uint256(_config.prices[1] - _config.prices[0]) > _numTicks); | ||
| require(_config.marketType != IMarket.MarketType.YES_NO, "YES/NO not permitted"); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.