Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update secp256k1 dep to 3.5.0 #332

Conversation

justinbarry
Copy link
Contributor

@justinbarry justinbarry commented Apr 12, 2018

See Clubhouse task

Also required this pr is accepted, released and the version dep updated within this project.

@justinbarry justinbarry force-pushed the justinbarry/ch8896/not-possible-to-build-augur-js-on-a-an-airplane branch from e88b1bb to 99e0485 Compare April 12, 2018 15:09
@tinybike tinybike self-assigned this Apr 15, 2018
Copy link
Member

@tinybike tinybike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I'm not clear why the secp256k1 dependency has anything to do with being able to build on airplanes (??)

@tinybike tinybike merged commit 792ef76 into master Apr 15, 2018
@tinybike tinybike deleted the justinbarry/ch8896/not-possible-to-build-augur-js-on-a-an-airplane branch April 15, 2018 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants