Improve integration test coverage #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto adrake/ch4304/improve-integration-test-coverage
…nto adrake/ch4304/improve-integration-test-coverage
nuevoalex
approved these changes
Jul 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does happy-path testing of disputing/forking and migrating to a child universe. I have not been able to figure out yet why the ETH balance does not change when calling
this.connector.ethjsQuery.getBalancein TestFixture.ts after doing transactions that should change the ETH balance, such as buying a complete set. Eventually, we should add ETH balance checks, but for now I am leaving this as a TODO item.