Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Summarize script crashes on Oddball files missing a position #68

Open
nohelix opened this issue Jul 18, 2023 · 1 comment
Open

Summarize script crashes on Oddball files missing a position #68

nohelix opened this issue Jul 18, 2023 · 1 comment
Labels
at: supervisor enhancement New feature or request
Milestone
v1.1: keep hit pe...

Comments

@nohelix
Copy link
Collaborator

nohelix commented Jul 18, 2023

Summarize script is built to require at least 1 trial at every position and crashes with an error saying that position must be 1 or 6 not X.
nohelix added a commit that referenced this issue Jul 18, 2023
@nohelix
Bug fix for Oddball
c515925 
Fixed script crashing out when there was not a minimum of one trial at each position (i.e. less than one completed block)
(see #68)

Note: This is a hacky fix. All I am doing is droping rows with less than 2 complete blocks. The MIT fix would be to check in the do loop down in line 786
@nohelix nohelix self-assigned this Jul 18, 2023
@nohelix nohelix added the enhancement New feature or request label Jul 18, 2023
@nohelix
Copy link
Collaborator Author

nohelix commented Jul 18, 2023

This is a hacky fix deployed in latest release (v1.0.5) . All I am doing is dropping rows with less than 2 complete blocks. The MIT fix would be to check in the do loop down in line 786 and then for any missing position put in a null.

@nohelix nohelix removed their assignment Jul 18, 2023
nohelix added a commit that referenced this issue Jul 27, 2023
@nohelix
Multiple runs in one day causes crash of sum.
03c9c08 
Short term fix for #68 caused by multiple runs in one day (#14 & #70)
@nohelix nohelix mentioned this issue Aug 26, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
at: supervisor enhancement New feature or request
Projects
None yet
Milestone
v1.1: keep hit percent in calc
Development

When branches are created from issues, their pull requests are automatically linked.

68-summarize-script-crashes-on-oddball-files-missing-a-position Auerbach-Lab/Behavior-autoanalysis
2 participants
@tofof @nohelix