Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hit or FA % #49

Open
nohelix opened this issue Mar 7, 2023 · 2 comments
Open

Hit or FA % #49

nohelix opened this issue Mar 7, 2023 · 2 comments
Labels
at: import/main.R at: shiny/app.R at: supervisor enhancement New feature or request priority: in progress
Milestone
TH calculation re...

Comments

@nohelix
Copy link
Collaborator

nohelix commented Mar 7, 2023

Ben would like to keep the Hit count, and hit % just like we do for FA %. This should probably happen with Gap as well. Note the necessary data is in the format_for_psycho and then accessible in caclulate_TH. See Detailed_FA for what the final form might look like

This probably means a big restructure of the run_archive:

  • keep Hit # and miss # similar to FA_detailed (for octave)
  • this makes the octave, gap and regular TH calculations similar and so they should all be structured the same, stored in the same place, etc

If we do the above, this will impact at least the following:
nohelix added a commit that referenced this issue Mar 15, 2023
@nohelix
Added new stats_detailed table to stats
b54bc0b 
This adds flexability for the future and fills the roll of the old FA_detailed.

It holds hits_detailed for graphing (see #49) which can be used in #33.

Prior to deployment, the old run_archive needs to be modified to match this format.
@nohelix
Copy link
Collaborator Author

nohelix commented Mar 15, 2023 •
edited
Loading

In old run_archive

  • Re-name FA_detailed to stats_detailed
  • calculate appropriate table for this

Check for issues with all subsequent usages. Most likely to have issues is Supervisor summary

nohelix added a commit that referenced this issue Mar 22, 2023
@nohelix
In progress rrun_archive fixer
cf34413 
Needed to fix run archive for #49
Need to consult on how to appropriately handle this as Reopening and every matlab file would be very slow and undesireable.

Therefore, I would like to just call the nested function of Calculate_Summary_Statistics on the archived trial data, but this doesn't appear to be possible.

The next best thing is copying a bunch of that function and recreating it which is bad for the obvious reasons.
@tofof tofof added priority: in progress enhancement New feature or request labels May 2, 2023
@tofof
Copy link
Collaborator

tofof commented Aug 10, 2023

#30 also deals with TH calculation issues, it may be possible to resolve it at the same time as resolving this

@tofof tofof added this to the TH calculation rework milestone Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
at: import/main.R at: shiny/app.R at: supervisor enhancement New feature or request priority: in progress
Projects
None yet
Milestone
TH calculation rework
Development

When branches are created from issues, their pull requests are automatically linked.

49-hit-percent Auerbach-Lab/Behavior-autoanalysis
2 participants
@tofof @nohelix