Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rxn Graph fails for reds, blues #45

Closed
tofof opened this issue Feb 17, 2023 · 1 comment
Closed

Rxn Graph fails for reds, blues #45

tofof opened this issue Feb 17, 2023 · 1 comment
Labels
bug Something isn't working priority: high

Comments

@tofof
Copy link
Collaborator

tofof commented Feb 17, 2023

In my dataset, the RXN graph fails for reds and blues. It succeeds for GP, purple, and orange. Others (green? lp/rp?) are untested.

Please modify Generate_Rxn_Graph() to avoid failure, and/or create a Generate_Second_Graph(row_added) helper function that acts as an intermediary, calls the correct graph generation function, and returns the graph generated by that call.

See Write_to_Archives() at the bottom for an example of using row_added in this way, namely
experiment = row_added$assignment %>% .[[1]] %>% pluck("experiment") where pluck is the secret sauce to deal with the list of list difficulty with assignment.

@tofof tofof added bug Something isn't working priority: high labels Feb 17, 2023
@nohelix
Copy link
Collaborator

nohelix commented Feb 25, 2023

This is expected as the reds are on Gap Detection which should be Duration vs. Rxn rather than Frequency.

  • Get graphing functions (ribbon vs range) coded independently
  • ID all the correct cases - e.g. 'ribbon' should work for Octave (phase = discrimination), Tones (non-oddball training)
  • Integrate into shiny interface

@nohelix nohelix mentioned this issue Feb 25, 2023
10 tasks
@nohelix nohelix removed their assignment Mar 7, 2023
nohelix added a commit that referenced this issue Mar 10, 2023
Better labeling both in location and now ID dashed line. Maybe should be folded in to #45 in prep for #33.
@tofof tofof closed this as completed Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority: high
Projects
None yet
Development

No branches or pull requests

2 participants