[C-4891] Add artist pick to mobile #9359

dylanjeffers · 2024-08-02T01:11:58Z

Description

Adds missing feature to mobile
Fixes hidden label
Adds ability to set/unset artist pick on hidden track

changeset-bot · 2024-08-02T01:12:02Z

⚠️ No Changeset found

Latest commit: a39c4a6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Kyle-Shanks · 2024-08-02T01:14:09Z

packages/mobile/src/components/drawers/ArtistPickConfirmationDrawer.tsx

+const messages = {
+  add: {
+    header: 'Set your Artist Pick',
+    description:
+      'This track will appear at the top of your profile, above your recent uploads, until you change or remove it.',
+    confirm: 'Set Track'
+  },
+  update: {
+    header: 'Change your artist pick?',
+    description:
+      'This track will appear at the top of your profile and replace your previously picked track.',
+    confirm: 'Change Track'
+  },
+  remove: {
+    header: 'Unset as Artist Pick',
+    description:
+      'Are you sure you want to remove your pick? This track will be displayed based on its release date.',
+    confirm: 'Unset Track'
+  }
+}


i like this

Kyle-Shanks · 2024-08-02T01:18:22Z

packages/web/src/components/track/GiantTrackTile.tsx

@@ -435,7 +435,7 @@ export const GiantTrackTile = ({
      isArtistPick,
      isUnlisted,
      includeEmbed: !(isUnlisted || isStreamGated),
-      includeArtistPick: !isUnlisted,
+      includeArtistPick: true,


do we not want to exclude unlisted tracks still?

chatted with sammie and we want to allow users to set artist pick on a hidden/scheduled track

Kyle-Shanks · 2024-08-02T01:19:41Z

packages/web/src/components/track/VisibilityLabel.tsx

-      </Text>
-    </Flex>
-  )
+  return null


it feels weird to have the return null at the end, but the if conditions are a lot cleaner so I agree with the changes

yeah kinda a catch all situation, but yeah odd agreed

Kyle-Shanks · 2024-08-02T01:19:57Z

packages/web/src/components/track/desktop/ConnectedTrackTile.tsx

@@ -149,6 +149,9 @@ const ConnectedTrackTile = ({
  const isTrackPlaying = isActive && isPlaying
  const isOwner = handle === userHandle
  const isArtistPick = showArtistPick && artist_pick_track_id === trackId
+  if (artist_pick_track_id === trackId) {
+    console.log('why??', showArtistPick)


Kyle-Shanks · 2024-08-02T01:20:22Z

packages/web/src/components/track/desktop/ConnectedTrackTile.tsx

@@ -198,7 +201,7 @@ const ConnectedTrackTile = ({
      handle,
      includeAddToPlaylist: !isUnlisted || isOwner,
      includeAddToAlbum: isOwner && !ddexApp,
-      includeArtistPick: handle === userHandle && !isUnlisted,
+      includeArtistPick: handle === userHandle,


same here, are we removing the unlisted condition for these?

Kyle-Shanks · 2024-08-02T01:22:42Z

packages/mobile/src/components/drawers/ArtistPickConfirmationDrawer.tsx

+  const dispatch = useDispatch()
+
+  const action = useMemo(
+    () => (!user?.artist_pick_track_id ? 'add' : trackId ? 'update' : 'remove'),


I think that I'm missing context here. Will trackId be passed sometimes and if it is passed, would that be remove or update?

yeah its a bit odd. what i noticed is that when you set the artist pick, as the drawer is closing user.artist_pick_track_id gets set which changes the action, resulting in it going from "add" to "remove" as it's sliding down. the memo ensures we only have one action through the lifecycle of the drawer.

Kyle-Shanks

A few comments to make sure that things made sense, but overall looks good

Kyle-Shanks · 2024-08-02T01:24:03Z

packages/mobile/src/components/drawers/ArtistPickConfirmationDrawer.tsx

+    confirm: 'Set Track'
+  },
+  update: {
+    header: 'Change your artist pick?',


should this header be sentence case like the others?

also is the question mark needed?

yes great callout. technically i think drawer title is cap-case but should be consistent

[7e9ef50] [C-4681] [C-4680] Add analytics for search v2 (#9363) Sebastian Klingler [d9b0c78] [PAY-3279] Fix misc web album UI issues (#9362) Raymond Jacobson [1b494ff] Improve SDK rewards claiming errors with RewardManagerError abstraction (#9214) Marcus Pasell [05720e3] [C-4891] Add artist pick to mobile (#9359) Dylan Jeffers [932ddc7] Add cors headers for actions (#9360) Raymond Jacobson [56409de] [C-4798] Filter all categories by verified (#9353) Sebastian Klingler [048a4d8] [PAY-3253] Fix confirmation drawer height (#9310) Dylan Jeffers [245baf4] [C-4915] Fix create collection card height (#9357) Dylan Jeffers [216a3fb] [C-4895] Fix profile screen verified badge (#9356) Dylan Jeffers [9500340] [C-4899] Fix isrc and iswc validation (#9352) Dylan Jeffers [7c780e8] Fix sign in (#9355) Dylan Jeffers [654e7a1] Add IconTowerBroadcast to harmony (#9354) Andrew Mendelsohn [a225c68] [PAY-3311] Create one_to_many_dms flag (#9351) Andrew Mendelsohn [6271d09] [C-4896] [C-4893] [C-4913] BPM precision adjustments (#9349) Sebastian Klingler [dc2a681] Remove null checks for metadata items in useXMetadata (#9350) Reed [06cbc13] Hide play counts for all gated content in TracksTable (#9347) Reed [4de149f] [C-4897] Improve empty edit collection page (#9346) Dylan Jeffers [67cbdfe] Update dapp-store build artifacts audius-infra [f1d908b] Fix show premium downloads message (#9344) Saliou Diallo [34445b8] [C-3907] Add empty state for artist results in sign up flow (#9343) Kyle Shanks [dc84357] add bpm edit flag col (#9324) Michelle Brier [b50abba] Add actions.json to cloudflare (#9341) Raymond Jacobson [8e9f6c3] [PAY-3283] Show high res artwork in edit (#9342) Raymond Jacobson [e91b12a] [C-4905] Fix app crash when navigating to let them dj when signed out (#9340) Kyle Shanks [8dbbd21] Add actions.json for solana blink support (#9331) Raymond Jacobson [3e70a7f] [QA-1374] Fix play/preview logic on track page (#9337) Dylan Jeffers [1e35fc3] [PAY-3298] Fix track preview generation (#9339) Dylan Jeffers [6867056] [C-4903] Update icon sizes for collection card actions and notifications (#9338) Kyle Shanks [6c7a231] [PAY-3271] Prevent navigation prompt from showing on delete (#9336) Andrew Mendelsohn [e1b8690] PAY-3290 Special Access should disable entirely (#9334) Marcus Pasell [0a64f84] PAY-3291 Don't show purchase in overflow menu for non-purchase-gated tracks (#9335) Marcus Pasell [0b2c061] PAY-3287 Validate main form on submitting access gate subform mobile (#9332) Marcus Pasell [9e81415] PAY-3288 Fix edit collection confirmations on mobile (#9330) Marcus Pasell [a3bfb57] Fix CollectionCard test (#9329) Sebastian Klingler [e6374bc] [PAY-3282] Prevent publishing 0 length playlist (#9328) Raymond Jacobson [b799fcb] typescript impl of R2(crc32) + R2(sha256) ordering. (#8942) Steve Perkins [eb8724e] PAY-3275 Portal drawers to the correct location (#9325) Marcus Pasell [f404f01] Remove legacy edit track (#9323) Andrew Mendelsohn [11f0ed5] [PAY-3274] Show 'releases today' on mobile (#9314) Andrew Mendelsohn [18f4bea] [PAY-3197] Remove gated-content-upload-prompt drawer (#9318) Reed [c36b94c] C-4894 Make edit track/edit collection use same buttons (#9321) Marcus Pasell [1b6a1b7] Migrate sign out confirmation drawer to harmony (#9320) Reed [7c8a654] [PAY-3254] Fix edit remix (#9322) Dylan Jeffers [9bd24c8] [C-4885] [C-4888] [C-4889] [C-4882] [C-4883] Advanced search UI fixes pt 3 (#9317) Sebastian Klingler [619da11] Fix "date required" error when selecting date (#9315) Dylan Jeffers [c29f8f8] [PAY-3277] Show release date for all public tracks/collections (#9313) Reed [885479a] Update users endpoints: round 1 (#9166) Randy Schott [8618e3c] PAY-3280 Fix gated access display (#9311) Marcus Pasell [69e76c7] [PAY-3276] No scheduled playlists (#9312) Dylan Jeffers [91197d4] [PAY-3262] Fix edit new playlist (#9309) Dylan Jeffers [1c61e0b] Update dn models (#9291) Randy Schott [cf20265] [PAY-3260] Use 'Today' for matching release dates (#9292) Andrew Mendelsohn [3290d1e] [PAY-3258] BoxedTextField can error before form submission (#9305) Saliou Diallo [1dd131f] [PAY-3248][PAY-3256][PAY-3234] Fix misc android issues (#9307) Raymond Jacobson [782e9d9] Premium extras updates (#9306) Dylan Jeffers [61cc53a] Small FilterButton hover style tweak (#9303) Sebastian Klingler [f7cf7d1] [QA-1448] Fix user badge spacing (#9302) Kyle Shanks [5af538a] [C-4868] BPM validation (#9295) Sebastian Klingler [22ca755] [C-4854] Add Premium Extras label (#9294) Dylan Jeffers [b66ca17] [PAY-3261] Update remix settings copy (#9299) Raymond Jacobson [f713455] [PAY-3236][PAY-3242][PAY-3259] Fix play button in tracks table (#9288) Saliou Diallo [d87357e] [PAY-3240] Prevent wrong users from seeing /edit pages (#9298) Raymond Jacobson [8b92b23] PAY-3233 Disable reset on select field for AM/PM (#9296) Marcus Pasell [3a63fbb] [PAY-3257] Default prices for premium albums/tracks (#9293) Andrew Mendelsohn [7d41d87] [C-4836] Adjust FilterButton active states (#9289) Sebastian Klingler [f680c81] [QA-1473] Fix duplicate purchase button in TracksTable row (#9284) Sebastian Klingler [97bf97d] Fix use-revert-on-cancel (#9286) Dylan Jeffers [2b9b811] Bump mobile to 109 (#9283) Dylan Jeffers [68ebca7] Update copy for preview length (#9280) Sebastian Klingler

[C-4891] Add artist pick to mobile

c60efc3

dylanjeffers requested review from a team and amendelsohn and removed request for a team August 2, 2024 01:12

pull-request-size bot added the size/L label Aug 2, 2024

dylanjeffers requested a review from a team August 2, 2024 01:12

Kyle-Shanks reviewed Aug 2, 2024

View reviewed changes

Kyle-Shanks approved these changes Aug 2, 2024

View reviewed changes

Kyle-Shanks reviewed Aug 2, 2024

View reviewed changes

Address comments

a39c4a6

dylanjeffers merged commit 05720e3 into main Aug 2, 2024
1 of 4 checks passed

dylanjeffers deleted the c-4891-mobile-artist-pick branch August 2, 2024 18:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[C-4891] Add artist pick to mobile #9359

[C-4891] Add artist pick to mobile #9359

dylanjeffers commented Aug 2, 2024

changeset-bot bot commented Aug 2, 2024 •

edited

Loading

Kyle-Shanks Aug 2, 2024

Kyle-Shanks Aug 2, 2024

dylanjeffers Aug 2, 2024

Kyle-Shanks Aug 2, 2024

dylanjeffers Aug 2, 2024

Kyle-Shanks Aug 2, 2024

Kyle-Shanks Aug 2, 2024

Kyle-Shanks Aug 2, 2024

dylanjeffers Aug 2, 2024

Kyle-Shanks left a comment

Kyle-Shanks Aug 2, 2024

Kyle-Shanks Aug 2, 2024

dylanjeffers Aug 2, 2024

[C-4891] Add artist pick to mobile #9359

[C-4891] Add artist pick to mobile #9359

Conversation

dylanjeffers commented Aug 2, 2024

Description

changeset-bot bot commented Aug 2, 2024 • edited Loading

⚠️ No Changeset found

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Kyle-Shanks left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

changeset-bot bot commented Aug 2, 2024 •

edited

Loading