Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PAY-3263] add playlists & albums release date if null #9304

Merged
merged 2 commits into from
Jul 30, 2024
Merged

[PAY-3263] add playlists & albums release date if null #9304

merged 2 commits into from
Jul 30, 2024

Conversation

raymondjacobson
Copy link
Member

Description

Old playlists & albums will get this set now

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 30, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: cec2c1d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@raymondjacobson raymondjacobson changed the title [PAY-3263] add playlists & albums release date [PAY-3263] add playlists & albums release date if nu Jul 30, 2024
@raymondjacobson raymondjacobson changed the title [PAY-3263] add playlists & albums release date if nu [PAY-3263] add playlists & albums release date if null Jul 30, 2024
amendelsohn
amendelsohn approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@amendelsohn amendelsohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I think this is safe

Have we stopped the creation of new rows without release_dates?

@raymondjacobson
Copy link
Member Author

Nice. I think this is safe

Have we stopped the creation of new rows without release_dates?

no new ones since early june!

@raymondjacobson raymondjacobson merged commit 28b71e0 into main Jul 30, 2024
12 checks passed
@raymondjacobson raymondjacobson deleted the rj-pay-3263 branch July 30, 2024 17:36
schottra added a commit that referenced this pull request Jul 30, 2024
@schottra
Merge remote-tracking branch 'origin/main' into pay-2917-user-endpoints
619d7b4 
* origin/main: (69 commits)
  Update dn models (#9291)
  [PAY-3260] Use 'Today' for matching release dates (#9292)
  [PAY-3258] BoxedTextField can error before form submission (#9305)
  [PAY-3248][PAY-3256][PAY-3234] Fix misc android issues (#9307)
  Premium extras updates (#9306)
  Silence request logs for python es client (#9301)
  [PAY-3263] add playlists & albums release date if null (#9304)
  Small FilterButton hover style tweak (#9303)
  [QA-1448] Fix user badge spacing (#9302)
  [C-4868] BPM validation (#9295)
  [C-4854] Add Premium Extras label (#9294)
  [PAY-3261] Update remix settings copy (#9299)
  Audius Protocol v0.6.158
  Longer deadline for fixing files (#9297)
  [PAY-3236][PAY-3242][PAY-3259] Fix play button in tracks table (#9288)
  [PAY-3240] Prevent wrong users from seeing /edit pages (#9298)
  PAY-3233 Disable reset on select field for AM/PM (#9296)
  [PAY-3249] Implement pnagD trending strategy (#9273)
  [PAY-3257] Default prices for premium albums/tracks (#9293)
  Pin Rust version to 1.79.0 (#9290)
  ...
schottra added a commit that referenced this pull request Jul 30, 2024
@schottra
Merge remote-tracking branch 'origin/main' into pay-3194-reposts-curr…
52c2765 
…ent-user

* origin/main: (74 commits)
  Update users endpoints: round 1 (#9166)
  PAY-3280 Fix gated access display (#9311)
  [PAY-3276] No scheduled playlists (#9312)
  [PAY-3262] Fix edit new playlist (#9309)
  Makefile improvements to core (#9300)
  Update dn models (#9291)
  [PAY-3260] Use 'Today' for matching release dates (#9292)
  [PAY-3258] BoxedTextField can error before form submission (#9305)
  [PAY-3248][PAY-3256][PAY-3234] Fix misc android issues (#9307)
  Premium extras updates (#9306)
  Silence request logs for python es client (#9301)
  [PAY-3263] add playlists & albums release date if null (#9304)
  Small FilterButton hover style tweak (#9303)
  [QA-1448] Fix user badge spacing (#9302)
  [C-4868] BPM validation (#9295)
  [C-4854] Add Premium Extras label (#9294)
  [PAY-3261] Update remix settings copy (#9299)
  Audius Protocol v0.6.158
  Longer deadline for fixing files (#9297)
  [PAY-3236][PAY-3242][PAY-3259] Fix play button in tracks table (#9288)
  ...
audius-infra pushed a commit that referenced this pull request Jul 31, 2024
Audius Protocol v0.6.159
3f0de30 
[08addb9] [PAY-3194] Pipe through user_id param if specified for reposts endopint (#9316) Randy Schott
[1c61e0b] Update dn models (#9291) Randy Schott
[3a73860] Silence request logs for python es client (#9301) Steve Perkins
[28b71e0] [PAY-3263] add playlists & albums release date if null (#9304) Raymond Jacobson
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dharit-tan dharit-tan dharit-tan approved these changes

@amendelsohn amendelsohn amendelsohn approved these changes

@sddioulde sddioulde Awaiting requested review from sddioulde

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raymondjacobson @amendelsohn @dharit-tan