[C-5579] Upgrade react router to v6 #10879
Conversation
|
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 11648676 | Triggered | Generic High Entropy Secret | 16a478d | cmd/core/infra/dev_config/discovery-one.docker.env | View secret |
| 11648678 | Triggered | Generic High Entropy Secret | 16a478d | cmd/core/infra/dev_config/content-three.docker.env | View secret |
| 11648679 | Triggered | Generic High Entropy Secret | 16a478d | cmd/core/infra/dev_config/content-two.docker.env | View secret |
| 11648680 | Triggered | Generic High Entropy Secret | 16a478d | cmd/core/infra/dev_config/content-one.docker.env | View secret |
| 9412812 | Triggered | Generic Password | 16a478d | dev-tools/compose/docker-compose.blockchain.yml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
dylanjeffers
requested review from
a team and
amendelsohn
and removed request for
a team
| @@ -499,7 +498,7 @@ function mapStateToProps(state: AppState, ownProps: OwnProps) { | |||
|
|
|||
| function mapDispatchToProps(dispatch: Dispatch) { | |||
| return { | |||
| goToRoute: (route: string, state?: LocationState) => | |||
| goToRoute: (route: string, state?: any) => | |||
There was a problem hiding this comment.
is there not a type we can use here?
| @@ -159,11 +158,11 @@ class CollectionPage extends Component< | |||
| updatingRoute: false | |||
| } | |||
|
|
|||
| unlisten!: UnregisterCallback | |||
| unlisten!: () => void | |||
There was a problem hiding this comment.
is this just not a thing anymore? can we remove unlisten or is it required?
Description
Upgrades us from react-router v5 to v6. The primary goal here is to reimplement tabs using router logic and Outlets which are introduced in v6. Additionally, moving to v7 can help us improve bundle-size which im interested in as well.
I'd also like to remove the router from our redux store, which we can do safely using saga context.