Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LEAN-3843 Improve steps communication between FE and BE #673

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

fwaisi
Copy link
Contributor

@fwaisi fwaisi commented Dec 2, 2024

@mnatsheh, I have made the following changes:

  1. made the current web-socket connection generic in order to reuse it instead of establishing a new one.
  2. I have kept the HTTP request as a fallback if the web socket connection not established correctly.
  3. I am sending the token in the payload in order to validate the request and fetch the retrieve the user in the API using it.

here is the API pr: Atypon-OpenSource/manuscripts-api#188

and would you please elaborate more on this: "The steps received on the websocket should be used instead of issuing a separate request to load steps."

@fwaisi fwaisi requested a review from mnatsheh December 2, 2024 10:28
Copy link
Contributor

zax-assistant bot commented Jan 22, 2025

Published version 3.7.12-LEAN-3843.0

Copy link
Contributor

zax-assistant bot commented Jan 23, 2025

Published version 3.7.16-LEAN-3843.0

Copy link
Contributor

zax-assistant bot commented Jan 26, 2025

Published version 3.7.20-LEAN-3843.0

Copy link
Contributor

zax-assistant bot commented Jan 27, 2025

Published version 3.7.23-LEAN-3843.0

Copy link
Contributor

zax-assistant bot commented Jan 28, 2025

Published version 3.7.24-LEAN-3843.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants