[Feature] Added support for linting style tags within html files #142
Conversation
| @@ -35,7 +35,7 @@ | |||
| "atom-package-deps": "^4.0.1", | |||
| "cosmiconfig": "^1.1.0", | |||
| "deep-assign": "^2.0.0", | |||
| "stylelint": "5.2.1", | |||
| "stylelint": "NEEDS UPDATING WHEN AVAILABLE", | |||
There was a problem hiding this comment.
Don't put this in, we'll simply not merge this until stylelint has been updated.
|
Can you add a spec testing that this is working? |
|
Thanks for getting this started btw! |
|
@Arcanemagus Now that @blake-newman has successfully merged his code into stylelint/stylelint#1019 Can we go ahead with this? For projects that use Polymer / WebComponents. Scoping |
|
@gaurav21r This still needs a spec, and a released version of |
|
@Arcanemagus @gaurav21r Will be updating this in the coming few days. |
|
@blake-newman I'd like to get this released soon, we're you planning on addressing the comments above and updating it for how the final implementation ended up? I can just pull your commit into a new PR and update it there if you don't have time right now 😉. |
blake-newman
force-pushed
the
feature/html-style-linting
branch
from
e22107c to
e30397f
Compare
blake-newman
changed the title
|
@Arcanemagus All is done :) |
| "stylelint-config-standard": "^7.0.0" | ||
| "deep-assign": "^2.0.0", | ||
| "stylelint": "^6.3.2", | ||
| "stylelint-config-standard": "^4.0.1" |
There was a problem hiding this comment.
It seems that master branch version is correct.
blake-newman
force-pushed
the
feature/html-style-linting
branch
from
e30397f to
10bf057
Compare
| "lazy-req": "^1.1.0", | ||
| "stylelint": "6.3.2", | ||
| "stylelint-config-standard": "^7.0.0" | ||
| "deep-assign": "^2.0.0", |
There was a problem hiding this comment.
It looks like your package.json changes are simply a reversion to a much older version... deep-assign was moved away from since it has many bugs.
|
@Arcanemagus looks as if when i rebased, i incorrectly resolved conflicts. All is resolved now. |
|
Okay, looking over the code now 😛. |
| @@ -24,6 +27,7 @@ describe('The stylelint provider for Linter', () => { | |||
| atom.workspace.destroyActivePaneItem(); | |||
| atom.config.set('linter-stylelint.useStandard', true); | |||
| atom.config.set('linter-stylelint.disableWhenNoConfig', false); | |||
| atom.config.set('linter-stylelint.enableHtmlLinting', false); | |||
There was a problem hiding this comment.
The default value is false, no need to explicitly set it to false here.
There was a problem hiding this comment.
I'm still seeing this in the diff?
|
LGTM after those minor nitpicks are addressed. The only thing I can think of that this isn't testing is whether SCSS or Less are linted properly in extracted HTML, but I'm perfectly fine with leaving that testing to |
- Added component option resolving (async to sync conversion) - Added grammar styles for embedded css - Added option to enable html linting
blake-newman
force-pushed
the
feature/html-style-linting
branch
from
10bf057 to
bab3d59
Compare
|
@Arcanemagus I tested placing If setting |
|
Commented again on those two parts |
|
Hmmm, I don't think this actually addresses one of my original comments: If HTML linting is enabled, and then disabled, does this still trigger on embedded CSS? |
| }, | ||
| enableHtmlLinting: { | ||
| title: 'Enable linting of styles within html', | ||
| description: 'Turn on linting of your styles tages within html files.', |
|
|
|
Merging this and fixing separately as I would like to get this released. Thanks for putting this together @blake-newman! |
|
Fixes are up in #194. |
|
Thanks a TON @Arcanemagus @blake-newman 👍 👍 👍 👍 💯 / 💯 |
Fixes #8.