This repository has been archived by the owner on Aug 7, 2023. It is now read-only.
Switch to scope activationHook from language package #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arcanemagus
suggested changes
Feb 27, 2019
When the package gets activated is controlled by the activationHook, however the package is still loaded on Atom startup. These should remain lazy loaded as before, however the deferred call in activate is no longer meaningful.
Arcanemagus
suggested changes
Feb 27, 2019
Looks like the file itself (linter-reek.js) is only loaded when the activation hook is triggered... but it blocks the opening of the file until the package is done calling activate(). This means that all the optimizations we were doing before to reduce the load during Atom's initial startup are still useful for packages that use activationHooks because we don't want to be blocking the UI any more than we must.
Looks like this is listed as a supported scope, but wasn't listed as activating the package.
Arcanemagus
approved these changes
Feb 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AtomLinter/Meta#20