This repository has been archived by the owner on Aug 7, 2023. It is now read-only.
actually use PYTHONPATH environment variable #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am not sure, why the check is failing or if it maybe should fail. On my computer, pylint always issues a missing module docstring warning as soon as I open an empty file (also with the currently released version of linter-pylint). But I am also not very used to javascript / coffeescript development, so maybe I miss something. Any thoughts? |
|
Merged in that PR as it looks like reviews had finished... only to find that commit had disappeared in one of their rebases. I've merged in a fix to the specs (and updated dependencies). Rebase your PR and the specs should be fixed. |
ChildProcess.spawn finally uses a for ... in loop over the env object, which discards all non-enumerable env attributes. This should fix AtomLinter#86 as well.
|
Thanks a lot, now it seems to be fine. |
SpainTrain
added a commit
that referenced
this pull request
Nov 30, 2015
actually use PYTHONPATH environment variable
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ChildProcess.spawn finally uses a for ... in loop
over the env object, which discards all non-enumerable
env attributes.
This should fix #86 as well.