This repository has been archived by the owner on Aug 7, 2023. It is now read-only.
Use project root as cwd #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have a pylint file in my project root that wasn't being found by `linter-pylint`. Looking into it, I discovered `@cwd` was `null` because `LinterPylint.constructor` never calls `super`. Test Plan: Opened a new Atom window in the directory that contains my pylint file and had pylint import things properly.
dmnd
added a commit
to dmnd/Linter
that referenced
this pull request
Jul 8, 2014
See AtomLinter/linter-pylint#8 for motivation for this. It's helpful to use the project root for Python linting at least. I suspect it would be useful more generally too. Feel free to close this request if you disagree. Test Plan: Crossed fingers
|
Is there any reason not to pull this? steelbrain/linter#127 will obsolete it but it seems people aren't yet convinced this is the right thing for the linter in general. It's definitely the right thing for pylint though, so can we pull this for now while steelbrain/linter#127 is discussed? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a pylintrc file in my project root that wasn't being found by
linter-pylint. Looking into it, I discovered@cwdwasnullbecauseLinterPylint.constructornever callssuper.Test Plan:
Opened a new Atom window in the directory that contains my pylintrc file and
had pylint import things properly.