-
Notifications
You must be signed in to change notification settings - Fork 48
Linter produces yellow marks in editor, but error/warning popup will not show #82
Comments
Can you share your |
Same here with vanilla setup (v1.2.0)... The yellow-dotted lines that also show a yellow-dashed underline do show the tooltip when clicked on, though. |
Have you disabled tooltips in Linter's configuration? Also Linter only decorates with dashed lines, so I'm not sure what the "yellow-dotted lines" would be from. A screenshot would be helpful there. Where is your cursor directed when you click on the "at line __ col ___" part of the message? |
Is the column 0 by any chance? 😛 |
No, it's not, but I think I found the problem: When I place the cursor manually at the exact column that's given in the error panel the tooltip pops up. If I place the cursor anywhere else on the affected line it doesn't. However, sometimes the marked column isn't even "accessible" due to indentation so the tooltip will never show up. Anyhow, the tooltip should appear as soon as the cursor is placed anywhere on a marked line, or, better yet, by hovering with mouse over the line (anywhere) or over the gutter marker. |
This is exactly what I see. Hints that I can't get tooltips or mouseovers On Fri, Jan 22, 2016 at 10:10 AM Oliver Bock [email protected]
The meek shall inherit the Earth, for the brave will be among the stars. |
So here is the odd thing: This should be generating highlight ranges that cover the line starting with the column that Do you have an example file you can share that shows the "dot with no line" behavior so we can look into it a bit further in detail? In the meantime you can enable the "Line" mode in the settings for Linter, then the bottom panel will show you all messages for the currently selected line. |
Sure, just cause an "Unused variable" warning (only works within functions for some reason):
This should also demonstrate the off-by-one problem which might even be the root cause: x is at column 5 but the error panel reports column 4 (5 is correct due to 4-space indentation). Thus you can't put the cursor manually on the spot when auto-indent is enabled. |
@Arcanemagus: any progress? I see the same issue with the simple test provided by @brevilo above. This problem crops up quite often. |
@sneakypete81 tl;dr CoffeeScript is terrible and this mess wasn't doing whatever the original author thought it was doing. On the good news, I've re-written this in ES6 and it seems to work fine so far 😛. I'll be putting that up in a PR shortly. |
Great to hear, thanks! |
* Move the configuration to "configSchema" in package.json for newer Atom versions * Fix #82 by fixing logic in the conditional for running rangeFromLineNumber
* Move the configuration to "configSchema" in package.json for newer Atom versions * Fix #82 by fixing logic in the conditional for running rangeFromLineNumber
@Arcanemagus: Really pleased that you've fixed this. It would be great to have a release pushed out with this fix. The last release was >6 months ago. Now that your rewrite is done, I'm sure shorter release cycles would be much appreciated by your many users. |
Hmmm, not sure why I didn't push out a release before, will look into that now. Thanks for the ping on getting that out 😉. |
v1.2.1 published, please file an issue if you see any problems! |
@Arcanemagus: thanks heaps, that release works beautifully. |
Sometimes I get a yellow marker in the gutter showing a warning is available, but no amount of hovering or clicking will cause the popup or tooltip to appear. There is also dashed line to show where the error is at.
The text was updated successfully, but these errors were encountered: