Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync translations via crowdin #153

Conversation

vjrj
Copy link
Contributor

@vjrj vjrj commented Aug 9, 2019

Sync of all crowding translations using #152

I synced in both directions because there was some translations (like ja, it, ru, da, nl, zh) not present in crowdin. And viceversa.

This include fixes for issues with quotes in strings with {0} parameters that should be escaped. See:

https://support.crowdin.com/configuration-file/#escape-quotes-options-for-properties-file-format
in several languages.

There are some issues with comments and blank lines from the source that are include in the export when the language is not totally translated.

I'm do some similar work with the translation of other repositories.

Copy link
Contributor

@ansell ansell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need confirmation of whether the empty line sections are expected.

grails-app/i18n/messages_da.properties Show resolved Hide resolved
@djtfmartin djtfmartin merged commit 37e142a into AtlasOfLivingAustralia:master Oct 15, 2019
@nickdos
Copy link
Contributor

nickdos commented Nov 5, 2019

@djtfmartin is this change redundant with the move to externalising the i18n files into /data/ directory?

@vjrj
Copy link
Contributor Author

vjrj commented Nov 5, 2019

Hi @nickdos we still use this crowdin conf to create the ala-i18n package and also to update crowdin from the github sources. ala-i18n don't store the translations, just upload-download from each ALA module when a translation is completed, or the source of messages to translate in modified in a github ALA module.
https://github.com/living-atlases/ala-i18n/blob/master/.gitmodules

I configured a pair of tasks in our jenkins that automatically do this for us. These jobs loops on each submodule to keep in sync in both directions. But for now only creates the ala-i18n package but don't update the ALA modules translations.

ala-i18n-jenkins

More info:
https://github.com/living-atlases/ala-i18n#continuous-integration

If in some moment ALA want to take care of these jobs and/or the apt repo and/or this LA repo, just ask.

@nickdos
Copy link
Contributor

nickdos commented Dec 23, 2019

QA done - in waiting for CAB for next release of collectory. Can wait for other bug fixes.

@ansell ansell self-requested a review July 8, 2020 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants