Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Downgrade to mapbox rc4, and pin 1.9.3 version of CocoaPods #653

Merged
merged 3 commits into from
Nov 8, 2020

Conversation

cbrevik
Copy link
Contributor

@cbrevik cbrevik commented Nov 8, 2020

This should fix the AppCenter build. Also looking at another fix for using latest CocoaPods with latest Mapbox, but still waiting on builds

@cbrevik cbrevik requested a review from mikaelbr November 8, 2020 20:20
@mikaelbr
Copy link
Collaborator

mikaelbr commented Nov 8, 2020

Saw this pods "fix" somewhere. I think it makes sense even if there isn't any bugs just to make it less brittle

@cbrevik
Copy link
Contributor Author

cbrevik commented Nov 8, 2020

Yeah I got it from here: https://github.com/react-native-mapbox-gl/maps/issues/1097#issuecomment-722351237

Makes sense! But it also makes build a bit slower. But oh well

@cbrevik cbrevik merged commit 770ce18 into master Nov 8, 2020
@cbrevik cbrevik deleted the cbrevik/pin-rc4-1.9.3 branch November 8, 2020 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants