Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Updates dependencies #568

Merged
merged 5 commits into from
Oct 21, 2020
Merged

chore: Updates dependencies #568

merged 5 commits into from
Oct 21, 2020

Conversation

mikaelbr
Copy link
Collaborator

@mikaelbr mikaelbr commented Oct 14, 2020

Updates all dependencies and migrates code where there are breaking changes.

Notable changes:

  • Better typing for react navigation and sub screens (previously wrong type info)
  • New API for Firebase Analytics
  • No longer exporting properties in json file as named exports.
  • Custom babel plugin to use @env as import for config files

Notable issues:

There is an issue with eslint-plugin-react-native in the latest version (see Intellicode/eslint-plugin-react-native#271) which affects us. Currently using an "older" version to avoid this.

@mikaelbr mikaelbr marked this pull request as ready for review October 19, 2020 08:13
@mikaelbr
Copy link
Collaborator Author

Don't know if this fixes any issue with the map on older iPhones, but at least we can specify custom SDK type here.

Copy link
Contributor

@cbrevik cbrevik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🐎 Just a couple of comments, nothing super-blocking

babel.config.js Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/diagnostics/trackNavigation.ts Show resolved Hide resolved
@mikaelbr mikaelbr merged commit e7435ed into master Oct 21, 2020
@mikaelbr mikaelbr deleted the mikael/update-deps branch October 21, 2020 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants