Skip to content
This repository has been archived by the owner on Sep 17, 2020. It is now read-only.

Handle with remove mothod on UpsertModal #23

Merged
merged 5 commits into from
Sep 25, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions lerna.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,15 @@
"packages": [
"packages/*"
],
"command": {
"publish": {
"conventionalCommits": true
},
"version": {
"message": "chore(version): bump",
"conventionalCommits": true
}
},
"version": "independent",
"npmClient": "yarn",
"useWorkspaces": true
Expand Down
9 changes: 9 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@
"postinstall-postinstall": "^2.0.0"
},
"devDependencies": {
"@commitlint/cli": "7.2.1",
"@commitlint/config-conventional": "7.1.2",
"husky": "1.2.1",
"lerna": "^3.14.1",
"lint-staged": "^7.0.0",
"pre-commit": "^1.2.2"
Expand All @@ -41,6 +44,12 @@
"**/lenses_ppx/**"
]
},
"husky": {
"hooks": {
"pre-commit": "npm run lint:staged",
"commit-msg": "commitlint -E HUSKY_GIT_PARAMS"
}
},
"scripts": {
"start": "lerna run bs:watch",
"test": "lerna run bs:build",
Expand Down
8 changes: 8 additions & 0 deletions packages/demo/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
# Change Log

All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

## [1.2.2](https://github.com/Astrocoders/astro-design/compare/[email protected]@1.2.2) (2019-09-25)

**Note:** Version bump only for package demo
4 changes: 2 additions & 2 deletions packages/demo/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "demo",
"private": true,
"version": "1.2.1",
"version": "1.2.2",
"scripts": {
"start": "react-scripts start",
"build": "react-scripts build",
Expand All @@ -17,7 +17,7 @@
"author": "",
"license": "MIT",
"dependencies": {
"@astrocoders/design": "^1.2.1",
"@astrocoders/design": "^1.3.0",
"bs-css": "^10.0.0",
"bs-react-icons": "astrocoders/bs-react-icons",
"postinstall-postinstall": "^2.0.0",
Expand Down
17 changes: 17 additions & 0 deletions packages/design/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
# Change Log

All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

# [1.3.0](https://github.com/Astrocoders/astro-design/compare/@astrocoders/[email protected]...@astrocoders/[email protected]) (2019-09-25)


### Bug Fixes

* **modal:** remove method arg ([bb4ceee](https://github.com/Astrocoders/astro-design/commit/bb4ceee))


### Features

* **modal:** handle with remove method ([9e5b75a](https://github.com/Astrocoders/astro-design/commit/9e5b75a))
* **packages:** add babel loader as dependency ([bf550bc](https://github.com/Astrocoders/astro-design/commit/bf550bc))
2 changes: 1 addition & 1 deletion packages/design/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@astrocoders/design",
"version": "1.2.1",
"version": "1.3.0",
"scripts": {
"start": "yarn storybook:start",
"build": "yarn storybook:build",
Expand Down
10 changes: 2 additions & 8 deletions packages/design/src/components/UpsertModal.re
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ module Styles = {
};

[@react.component]
let make = (~method, ~displayName, ~opener, ~content, ~className="") =>
let make = (~displayName, ~opener, ~content, ~className="") =>
<Modal
opener
content={(~close) =>
Expand All @@ -25,13 +25,7 @@ let make = (~method, ~displayName, ~opener, ~content, ~className="") =>
justify=Css.flexStart
pBottom=0
className=Styles.title>
{Utils.str(
switch (method) {
| `insert => "Insert"
| `update => "Update"
},
)}
{Utils.str(" " ++ displayName)}
{React.string(displayName)}
</Title>
<Button
type_=`transparent
Expand Down
Loading