Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(java): use jdtls for formatting instead of clang-format #888

Merged
merged 3 commits into from
Apr 16, 2024

Conversation

Juniar-Rakhman
Copy link
Contributor

📑 Description

In the java pack, clang_formatter is unnecessary. It also overrides the formatting capability of "mfussenegger/nvim-jdtls".

Having clang_formatter for java pack does not make sense, as the default formatter works just fine.

list of changes:

  • removed unnecessary clang_formatter and everything related to it.
  • updated readme to include custom formatter example.

Copy link

github-actions bot commented Apr 16, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

lua/astrocommunity/pack/java/README.md Outdated Show resolved Hide resolved
@mehalter mehalter changed the title fix(pack-java): remove clang-formatter fix(java): remove clang-formatter Apr 16, 2024
@mehalter mehalter changed the title fix(java): remove clang-formatter fix(java): use jdtls for formatting instead of clang-format Apr 16, 2024
Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mehalter mehalter merged commit 70754e5 into AstroNvim:main Apr 16, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants