-
-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(coq_nvim): fix coq bindings #798
Conversation
Review ChecklistDoes this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist: Proper conventional commit scoping:
|
@tku137 We use in astronvim, so i think we should use the same key here. |
@Uzaaft sorry I can't follow. What do we use in astronvim? |
Lol my message was written in haste. |
a8ba9d6
to
f35d9bd
Compare
Good point, thanks. I just changed it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
📑 Description
After coq is lazy loaded, meaning after the first autocompletion is triggered, it's default binding
<C-h>
forjump_to_mark
(https://github.com/ms-jpq/coq_nvim/blob/coq/docs/SNIPS.md#snippets) clashes with AstroNVims window movement. Basically, as soon as coq is loaded, you can't switch to the left window anymore.This is an attempt to fix that. I chose
<C-t>
to jump to the next snippet edit, which is absolutely a debatable choice. I think this clashes the least with both AstroNVims and Neovims default bindings.