Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pack): add Templ language pack #780

Merged
merged 1 commit into from
Mar 1, 2024
Merged

feat(pack): add Templ language pack #780

merged 1 commit into from
Mar 1, 2024

Conversation

mehalter
Copy link
Member

@mehalter mehalter commented Mar 1, 2024

📑 Description

This adds a pack for the Templ HTML templating language

ℹ Additional Information

Copy link

github-actions bot commented Mar 1, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

@Uzaaft
Copy link
Member

Uzaaft commented Mar 1, 2024

@mehalter Doesn't templ require go? Shouldnt that be included in the pack, or mentioned in the docs.

@mehalter
Copy link
Member Author

mehalter commented Mar 1, 2024

No it doesn't seem to require go

@mehalter
Copy link
Member Author

mehalter commented Mar 1, 2024

I mean to run the language server on a .templ file and to parse the treesitter it doesn't require Go

@mehalter
Copy link
Member Author

mehalter commented Mar 1, 2024

we could add it tho

@mehalter
Copy link
Member Author

mehalter commented Mar 1, 2024

oh actually it very much doesn't require gopls or anything. So it is good as is

@mehalter mehalter merged commit bbd7f7f into main Mar 1, 2024
13 checks passed
@mehalter mehalter deleted the templ branch March 1, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants