Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(main): Add type hints to all opts usage for catppuccin/nvim. Catch bug in opts usage for catppuccin #695

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

Uzaaft
Copy link
Member

@Uzaaft Uzaaft commented Dec 28, 2023

No description provided.

Copy link

github-actions bot commented Dec 28, 2023

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

@luxus luxus changed the title feat(main): Add type hints to all opts usage for catppuccin/nvim. Catch bug in opts usage for catppuccin feat(catppuccin): Add type hints to all opts usage for catppuccin/nvim. Catch bug in opts usage for catppuccin Jan 10, 2024
@luxus
Copy link
Member

luxus commented Jan 10, 2024

is this title still okay? feat(main) didn't passed the "Conventional Commit Title (pull_request_target)" @Uzaaft

@Uzaaft
Copy link
Member Author

Uzaaft commented Jan 11, 2024

is this title still okay? feat(main) didn't passed the "Conventional Commit Title (pull_request_target)" @Uzaaft

We’ve used feat(main) before. I was just waiting on mehalter coming back from his vacay. feat(catppuccin) is def wrong

@luxus luxus changed the title feat(catppuccin): Add type hints to all opts usage for catppuccin/nvim. Catch bug in opts usage for catppuccin feat(main): Add type hints to all opts usage for catppuccin/nvim. Catch bug in opts usage for catppuccin Jan 11, 2024
@luxus luxus changed the title feat(main): Add type hints to all opts usage for catppuccin/nvim. Catch bug in opts usage for catppuccin feat(colorscheme): Add type hints to all opts usage for catppuccin/nvim. Catch bug in opts usage for catppuccin Jan 11, 2024
@luxus
Copy link
Member

luxus commented Jan 11, 2024

i checked the possible options feat(colorscheme): is fine.. is this fitting enough? @Uzaaft @mehalter

@Uzaaft Uzaaft changed the title feat(colorscheme): Add type hints to all opts usage for catppuccin/nvim. Catch bug in opts usage for catppuccin feat(main): Add type hints to all opts usage for catppuccin/nvim. Catch bug in opts usage for catppuccin Jan 11, 2024
@Uzaaft
Copy link
Member Author

Uzaaft commented Jan 11, 2024

i checked the possible options feat(colorscheme): is fine.. is this fitting enough? @Uzaaft @mehalter

Let it stay as is.

@mehalter mehalter merged commit 3c0d274 into main Jan 11, 2024
22 of 25 checks passed
@mehalter mehalter deleted the feat/typings branch January 11, 2024 17:30
@mehalter
Copy link
Member

well now that I think about it, this probably should have just been docs or something rather than feat since this doesn't change anything about the functionality and just provides documentation of the types in lua 🤷🏼

@Uzaaft
Copy link
Member Author

Uzaaft commented Jan 11, 2024

Should we edit the commit text? @mehalter

@mehalter
Copy link
Member

Nah 😂 not bad haha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants