Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(oil-nvim): ssh support #614

Merged
merged 1 commit into from
Oct 25, 2023
Merged

fix(oil-nvim): ssh support #614

merged 1 commit into from
Oct 25, 2023

Conversation

meijieru
Copy link
Contributor

📑 Description

oil.nvim is equipped to handle oil-ssh://, as demonstrated here.
However, attempting to lazy load it may result in an error when using nvim oil-ssh//xxx.

ℹ Additional Information

@github-actions
Copy link

github-actions bot commented Oct 18, 2023

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

@luxus
Copy link
Member

luxus commented Oct 24, 2023

i wonder how many people are using this. i guess its the minority and I'm not sure if it makes sense to sacrifify lazyloading on the plugin.
the official installation doesn't have lazy disabled as well.

@Uzaaft
Copy link
Member

Uzaaft commented Oct 25, 2023

i wonder how many people are using this. i guess its the minority and I'm not sure if it makes sense to sacrifify lazyloading on the plugin. the official installation doesn't have lazy disabled as well.

The config of the oil.nvim author doesn't lazy load oil.nvim, so I think we shouldn't.
@meijieru feel free to change this PR so that the only diff is that lazy = false

@meijieru
Copy link
Contributor Author

i wonder how many people are using this. i guess its the minority and I'm not sure if it makes sense to sacrifify lazyloading on the plugin. the official installation doesn't have lazy disabled as well.

The config of the oil.nvim author doesn't lazy load oil.nvim, so I think we shouldn't. @meijieru feel free to change this PR so that the only diff is that lazy = false

Done.

@Uzaaft Uzaaft merged commit d4a5520 into AstroNvim:main Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants