Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(haskell): remove now redundant discover_configurations call #570

Merged
merged 1 commit into from
Sep 10, 2023
Merged

fix(haskell): remove now redundant discover_configurations call #570

merged 1 commit into from
Sep 10, 2023

Conversation

mrcjkb
Copy link
Contributor

@mrcjkb mrcjkb commented Sep 10, 2023

📑 Description

@Uzaaft @Per48edjes

ℹ Additional Information

The 2.1.0 change is backward compatible, but the discover_configurations call is now redundant.

@github-actions
Copy link

github-actions bot commented Sep 10, 2023

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

- Since version 2.1.0, haskell-tools.nvim calls this automatically
if both `nvim-dap` and `haskell-debug-adapter` are installed.
@Uzaaft Uzaaft merged commit 59df499 into AstroNvim:main Sep 10, 2023
@mrcjkb mrcjkb deleted the haskell-tools-2-1-0 branch September 11, 2023 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants