Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(python): Adds Imports Sorting with isort to the Python Pack #551

Merged
merged 5 commits into from
Sep 5, 2023

Conversation

WaelKarkoub
Copy link
Contributor

📑 Description

It's a common way to sort Python imports on save. ruff_lsp could be used to sort the imports the exact same way through code actions, but I'm not sure how to do that on file save.

It's a common way to sort Python imports on save. `ruff_lsp` could be used to sort the imports the exact same way through code actions, but I'm not sure how to do that here on save.
@github-actions
Copy link

github-actions bot commented Sep 1, 2023

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

@WaelKarkoub WaelKarkoub changed the title Adds isort to Python Pack feat(pack): Adds Imports Sorting with isort to the Python Pack Sep 1, 2023
@WaelKarkoub WaelKarkoub changed the title feat(pack): Adds Imports Sorting with isort to the Python Pack fix(pack): Adds Imports Sorting with isort to the Python Pack Sep 1, 2023
@WaelKarkoub WaelKarkoub changed the title fix(pack): Adds Imports Sorting with isort to the Python Pack fix(python-pack): Adds Imports Sorting with isort to the Python Pack Sep 1, 2023
Copy link
Member

@Uzaaft Uzaaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add isort to the readme as well.

@Uzaaft Uzaaft changed the title fix(python-pack): Adds Imports Sorting with isort to the Python Pack fix(python): Adds Imports Sorting with isort to the Python Pack Sep 2, 2023
@WaelKarkoub
Copy link
Contributor Author

@Uzaaft just updated the readme ✔️

@Uzaaft Uzaaft self-requested a review September 5, 2023 10:53
@Uzaaft Uzaaft merged commit 2fe93b3 into AstroNvim:main Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants