Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cpp): update clangd_extensions plugin to new setup process #513

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

mehalter
Copy link
Member

@mehalter mehalter commented Aug 9, 2023

📑 Description

clangd_extensions recently made some significant breaking changes where it doesn't actually do anything except add commands. So we can just have it load on the file types and we are good to go!

ℹ Additional Information

Extra people testing this would be super helpful!

@mehalter mehalter requested a review from a team August 9, 2023 16:14
@github-actions
Copy link

github-actions bot commented Aug 9, 2023

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

@mehalter mehalter marked this pull request as draft August 9, 2023 16:26
@mehalter mehalter marked this pull request as ready for review August 9, 2023 16:33
@mehalter
Copy link
Member Author

mehalter commented Aug 9, 2023

@Uzaaft for AstroNvim v4 we should probably just have this fully lazy loaded and then load the plugin with the clangd on_attach method! 🚀

@Uzaaft
Copy link
Member

Uzaaft commented Aug 9, 2023

Shouldn't this PR add back clangd, since the plugin itself doesn't do that anymore?

@mehalter
Copy link
Member Author

mehalter commented Aug 9, 2023

@Uzaaft it does that, it removes the line that skips the setup. clangd is already in the mason-lspconfig setup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants