Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nvim-scrollbar): Fix issue with is_available calls #351

Merged
merged 4 commits into from
Jul 2, 2023
Merged

fix(nvim-scrollbar): Fix issue with is_available calls #351

merged 4 commits into from
Jul 2, 2023

Conversation

Uzaaft
Copy link
Member

@Uzaaft Uzaaft commented Jul 2, 2023

No description provided.

@github-actions
Copy link

github-actions bot commented Jul 2, 2023 •
edited by mehalter
Loading

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

mehalter
mehalter requested changes Jul 2, 2023
View reviewed changes
Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move the utilities import into the opts function

@Uzaaft
Copy link
Member Author

Uzaaft commented Jul 2, 2023

Can you move the utilities import into the opts function

Done

mehalter
mehalter approved these changes Jul 2, 2023
View reviewed changes
Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mehalter mehalter merged commit d776458 into main Jul 2, 2023
@mehalter mehalter deleted the fix/nvim-scrollbar branch July 2, 2023 21:00
@mehalter mehalter mentioned this pull request Jul 2, 2023
Merged
Uzaaft added a commit that referenced this pull request Jul 3, 2023
@Uzaaft
fix(nvim-scrollbar): Fix issue with is_available calls (#351)
7dea7ba 
* fix(nvim-scrollbar): Fix issue with is_available calls

* fix(nvim-scrollbar): extend opts with function

* chore(nvim-scrollbar): Remove unnessecary import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mehalter mehalter mehalter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Uzaaft @mehalter