Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(copilotchat-nvim)!: update to v3 #1292

Merged

Conversation

ALameLlama
Copy link
Member

Closes #1291

📑 Description

Updates to v3 and removes the opts window changes as they have issues with window resizing and other issues when trying to move buffers around

ℹ Additional Information

They've updated the prompt actions
CopilotC-Nvim/CopilotChat.nvim@v2.16.0...v3.0.0#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5L120-L128

help_actions was deprecated and now just uses prompt actions
CopilotC-Nvim/CopilotChat.nvim@v2.16.0...v3.0.0#diff-48b86e8f407d8316ff351556d1495ecbe87b72a450d19713b83829c5165eba37R10-R12

I've removed the opts windows setting since they are too personal and was causing issues. people can add it into their own configs

    window = {
      layout = "float",
      width = 74, -- absolute width in columns
      height = vim.o.lines - 4, -- absolute height in rows, subtract for command line and status line
      row = 1, -- row position of the window, starting from the top
      col = vim.o.columns - 74, -- column position of the window, aligned to the right
    },

Copy link

github-actions bot commented Dec 18, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

  • Proper usage of opts table rather than setting things up with the config function.

  • Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

@Uzaaft Uzaaft merged commit 38ab808 into AstroNvim:main Dec 18, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update copilotchat-nvim to version 3
2 participants