Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pack): add csharp support with omnisharp #1241

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

ahmtsen
Copy link
Contributor

@ahmtsen ahmtsen commented Oct 13, 2024

📑 Description

This PR adds C# language support with omnisharp as LSP

ℹ Additional Information

Copy link

github-actions bot commented Oct 13, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

  • Proper usage of opts table rather than setting things up with the config function.

  • Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

@ahmtsen ahmtsen changed the title feat(cs-omnisharp): add csharp support with omnisharp feat(pack): add csharp support with omnisharp Oct 13, 2024
@ahmtsen
Copy link
Contributor Author

ahmtsen commented Oct 25, 2024

@mehalter when will this PR be merged?

@ALameLlama
Copy link
Member

@AstroNvim/astrocommunity-maintainers This looks fine to me, it's similar to the CS pack but the LSP is different, should this be a separate pack or is there a way to can make it option and only have 1 CS pack?

@Uzaaft
Copy link
Member

Uzaaft commented Nov 4, 2024

@AstroNvim/astrocommunity-maintainers This looks fine to me, it's similar to the CS pack but the LSP is different, should this be a separate pack or is there a way to can make it option and only have 1 CS pack?

i think this is fine as is tbh

@ALameLlama
Copy link
Member

Ship it

@ALameLlama ALameLlama merged commit d0a4350 into AstroNvim:main Nov 7, 2024
14 checks passed
mehalter pushed a commit that referenced this pull request Nov 7, 2024
feat(cs-omnisharp): add csharp support with omnisharp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants