Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pack): add an NvChad UI pack #1230

Merged
merged 1 commit into from
Oct 4, 2024
Merged

feat(pack): add an NvChad UI pack #1230

merged 1 commit into from
Oct 4, 2024

Conversation

mehalter
Copy link
Member

@mehalter mehalter commented Oct 3, 2024

📑 Description

Add a pack for integrating the NvChad UI toolkit in AstroNvim

ℹ Additional Information

Copy link

github-actions bot commented Oct 3, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

  • Proper usage of opts table rather than setting things up with the config function.

  • Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

@mehalter mehalter force-pushed the nvchad branch 2 times, most recently from 1ddac75 to 577f559 Compare October 3, 2024 16:27
@luxus
Copy link
Member

luxus commented Oct 3, 2024

wolf in sheep's clothing

@Uzaaft
Copy link
Member

Uzaaft commented Oct 4, 2024

Whats blocking this PR?

@mehalter
Copy link
Member Author

mehalter commented Oct 4, 2024

@Uzaaft NvChad/ui doesn't currently actually support loading configuration like this. So it doesn't fully work. Once that gets added (if it does) then I can test this more and add the rest of the missing stuff like leybindings and whatnot

@mehalter mehalter marked this pull request as ready for review October 4, 2024 13:39
@mehalter mehalter requested a review from a team October 4, 2024 13:39
@mehalter
Copy link
Member Author

mehalter commented Oct 4, 2024

@Uzaaft I opened some PRs upstream to add the missing support and now this PR works great!

@mehalter mehalter force-pushed the nvchad branch 2 times, most recently from 23efe8f to 387bdda Compare October 4, 2024 13:57
@Uzaaft
Copy link
Member

Uzaaft commented Oct 4, 2024

Fuck it, ship it

@mehalter mehalter merged commit 6c63df9 into main Oct 4, 2024
14 checks passed
@mehalter mehalter deleted the nvchad branch October 4, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants