Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pack): pass astrolsp.on_attach() to moonbit.nvim #1225

Closed
wants to merge 1 commit into from

Conversation

rami3l
Copy link
Contributor

@rami3l rami3l commented Sep 27, 2024

📑 Description

After installing the moonbit pack, moonbit-lsp still won't launch properly.
This looks like an oversight in #1224. (cc @mehalter)

Tested locally with the following override:

  {
    "tonyfettes/moonbit.nvim",
    opts = function(_, opts)
      -- only enable treesitter if the plugin is available
      if not require("astrocore").is_available("nvim-treesitter") then
        opts.treesitter = { enabled = false }
      end
      -- only enable the LSP if the lsp command is executable
      if vim.fn.executable("moonbit-lsp") == 1 then
        local astrolsp_avail, astrolsp = pcall(require, "astrolsp")
        if astrolsp_avail then
          opts.lsp = astrolsp.lsp_opts("moonbit")
          opts.on_attach = astrolsp.on_attach
        end
      else
        opts.lsp = false
      end
    end,
  },

Copy link

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

  • Proper usage of opts table rather than setting things up with the config function.

  • Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

@mehalter
Copy link
Member

This is incorrect, sorry!

@mehalter mehalter closed this Sep 27, 2024
@mehalter
Copy link
Member

There is no opts.on_attach option in moonbit.nvim

@mehalter
Copy link
Member

I can confirm with a base installation with just this pack as is the moonbit LSP attached correctly

@rami3l
Copy link
Contributor Author

rami3l commented Sep 27, 2024

There is no opts.on_attach option in moonbit.nvim

That's right, my bad :| Maybe I just forgot to restart Neovim so I might be "solving" an inexistent issue...

Thanks again for the quick response :]

@rami3l rami3l deleted the patch-1 branch September 27, 2024 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants