WIP: Improved camera error handling by adding new camera & focuser property to Pyro interface #208
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new camera and focuser properties to the Pyro interface so that they can be used in huntsman-pocs.
Specifically:
.can_take_internal_darks
property (read only). This isn't actually anything to do with error handling but it's in POCSdevelop
now so should be accessible for huntsman-pocs remote cameras too..exposure_error
property (read only). This will beNone
unless the most recent exposure taken by the camera raised an exception, in which case it will be equal to the string representation of that exception. By checking this after an exposure (or observation) has completed it is possible for calling code to detect cameras errors and respond accordingly, e.g. deleting failed cameras from the camera list..autofocus_make_plots
property (read/write), can be used to check or set whether to produce the autofocus plots. This can still be overriden by setting themake_plots
argument of the call toautofocus()
..autofocus_error
property (read only). This will beNone
unless the most recent autofocus taken by the focuser raise an exception, in which case it will be equal to the string representation of that exception. By checking this after an autofocus sequence has complete it is possible for calling code to detect camera errors and respond accordingly, e.g. deleting failed cameras from the camera list.Note: Apart from
.can_take_internal_darks
these new properties do not exist in POCSdevelop
, only in the https://github.com/AnthonyHorton/POCS/tree/error-handling branch. See PR panoptes/POCS#1003 for more details.