Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Improved camera error handling by adding new camera & focuser property to Pyro interface #208

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

AnthonyHorton
Copy link
Member

Add new camera and focuser properties to the Pyro interface so that they can be used in huntsman-pocs.

Specifically:

  1. Camera .can_take_internal_darks property (read only). This isn't actually anything to do with error handling but it's in POCS develop now so should be accessible for huntsman-pocs remote cameras too.
  2. Camera .exposure_error property (read only). This will be None unless the most recent exposure taken by the camera raised an exception, in which case it will be equal to the string representation of that exception. By checking this after an exposure (or observation) has completed it is possible for calling code to detect cameras errors and respond accordingly, e.g. deleting failed cameras from the camera list.
  3. Focuser .autofocus_make_plots property (read/write), can be used to check or set whether to produce the autofocus plots. This can still be overriden by setting the make_plots argument of the call to autofocus().
  4. Focuser .autofocus_error property (read only). This will be None unless the most recent autofocus taken by the focuser raise an exception, in which case it will be equal to the string representation of that exception. By checking this after an autofocus sequence has complete it is possible for calling code to detect camera errors and respond accordingly, e.g. deleting failed cameras from the camera list.

Note: Apart from .can_take_internal_darks these new properties do not exist in POCS develop, only in the https://github.com/AnthonyHorton/POCS/tree/error-handling branch. See PR panoptes/POCS#1003 for more details.

@AnthonyHorton
Copy link
Member Author

These changes should at least partially fix #205.

@lspitler lspitler mentioned this pull request Sep 14, 2020
@danjampro
Copy link
Contributor

@AnthonyHorton Is this still under development?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants