Update egui to 0.24 #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My computer is one of those that get blurry web rendering when the width of the canvas is an odd number of pixels. But in this modified version of eframe's web runner, rounding the width to an even number of pixels is actually what's causing the blurry rendering, so I've removed it.
melody-rs
approved these changes
Dec 11, 2023
white-axe
added a commit
to white-axe/Luminol
that referenced
this pull request
Dec 13, 2023
In egui 0.24, the scrollbars no longer take up any space by default and only appear when you hover over where the scrollbar is supposed to be. So since Astrabit-ST#75, the tilepicker width was incorrectly including the width of the scrollbar in the width calculation, making the tilepicker too wide. This removes the width of the scrollbar from the tilepicker width formula so that the tilepicker default width and maximum width are calculated correctly.
melody-rs
pushed a commit
that referenced
this pull request
Dec 13, 2023
* Fix tilepicker being too wide by default In egui 0.24, the scrollbars no longer take up any space by default and only appear when you hover over where the scrollbar is supposed to be. So since #75, the tilepicker width was incorrectly including the width of the scrollbar in the width calculation, making the tilepicker too wide. This removes the width of the scrollbar from the tilepicker width formula so that the tilepicker default width and maximum width are calculated correctly. * Fix tilepicker scroll position changing when map is modified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now that catppuccin-egui has updated their egui dependency, we can as well. This pull request updates egui to 0.24.1 and merges from upstream eframe and egui-wgpu 0.24.1.
Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknowncargo build --releasetrunk build --release