feat: add module feeburn #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
December 20, 2022 10:37
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| fmt.Println("total fee", totalFees) | ||
| fmt.Println("total fee burn", feeBurn) | ||
| addr, _ := sdk.AccAddressFromBech32("astra17xpfvakm2amg962yls6f84z3kell8c5lnnwrnp") |
Check warning
Code scanning / gosec
Returned error is not propagated up the stack.
| @@ -221,7 +236,14 @@ | |||
| encodingConfig := encoding.MakeConfig(app.ModuleBasics) | |||
| suite.clientCtx = client.Context{}.WithTxConfig(encodingConfig.TxConfig) | |||
| suite.ethSigner = ethtypes.LatestSignerForChainID(suite.app.EvmKeeper.ChainID()) | |||
|
|
|||
| err = suite.app.BankKeeper.MintCoins(suite.ctx, minttypes.ModuleName, sdk.Coins{{Denom: config.BaseDenom, Amount: sdk.NewInt(int64(math.Pow10(18) * 1))}}) | |||
Check notice
Code scanning / CodeQL
Floating point arithmetic
Codecov Report
@@ Coverage Diff @@
## main #156 +/- ##
==========================================
- Coverage 74.79% 72.98% -1.82%
==========================================
Files 22 17 -5
Lines 1857 1573 -284
==========================================
- Hits 1389 1148 -241
+ Misses 428 402 -26
+ Partials 40 23 -17
|
| err = suite.app.BankKeeper.MintCoins(suite.ctx, minttypes.ModuleName, sdk.Coins{{Denom: config.BaseDenom, Amount: sdk.NewInt(int64(math.Pow10(18) * 1))}}) | ||
| require.NoError(t, err) | ||
| suite.Commit() | ||
| feePoolBalance := sdk.Coins{{Denom: config.BaseDenom, Amount: sdk.NewInt(int64(math.Pow10(18) * 1))}} |
Check notice
Code scanning / CodeQL
Floating point arithmetic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #XXX
PR Checklist:
make)make test)go fmt)golangci-lint run)go list -json -m all | nancy sleuth)Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.
I have...