Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make random test deterministic #512

Merged
merged 1 commit into from
Nov 24, 2024
Merged

Make random test deterministic #512

merged 1 commit into from
Nov 24, 2024

Conversation

hugobuddel
Copy link
Collaborator

Fixes https://github.com/AstarVienna/ScopeSim/actions/runs/11993399220/job/33434342724

>       assert np.sum(fov_back.hdu.data) == approx(sum_orig, rel=1E-2)
E       assert 146.45611957005417 == 148.0 ± 1.5e+00
E         comparison failed
E         Obtained: 146.45611957005417
E         Expected: 148.0 ± 1.5e+00

@hugobuddel hugobuddel requested a review from teutoburg November 24, 2024 10:41
Copy link

codecov bot commented Nov 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.04%. Comparing base (dde7c34) to head (603d61e).
Report is 61 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #512   +/-   ##
=======================================
  Coverage   77.04%   77.04%           
=======================================
  Files          66       66           
  Lines        8204     8204           
=======================================
  Hits         6321     6321           
  Misses       1883     1883           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@teutoburg teutoburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've been bothered by these random fails for a while, but never quite enough to do something about it. Let's just this was the only one of its kind...

@hugobuddel hugobuddel merged commit fbe8ce9 into main Nov 24, 2024
22 checks passed
@hugobuddel hugobuddel deleted the hb/fixrandomtest branch November 24, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants