-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for package and mode status keywords #509
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #509 +/- ##
==========================================
- Coverage 77.16% 77.08% -0.09%
==========================================
Files 66 66
Lines 8204 8218 +14
==========================================
+ Hits 6331 6335 +4
- Misses 1873 1883 +10 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Now codecough is complaining, perhaps we should put a status also in |
I think we should indeed test this, otherwise it will bite us at some point. Or it is implicitly tested through the IRDB I guess right? (Maybe we should add coverage support to ScopeSim_Data?) |
Turns out, codecov is useful after all...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verbally discussed. In Ordnung 👍
Sibling of AstarVienna/irdb#201.