Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uplift to the latest Storybook and Vite #83

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

bobo-k2
Copy link
Contributor

@bobo-k2 bobo-k2 commented Aug 24, 2023

Uplifted all dependencies and yarn to v3 (to be able to uplift Storybook)

Storybook was updated by running yarn dlx storybook@latest upgrade

After the uplift build:types command was failing with errors described here occurs. Most likely because Vue and React conflicts (React dependencies are mandatory and used by Storybook).
To fix the errors I added rm -rf ./node_modules/@types/react to the build:types command.

That's not all. After the fix above build:lib was failing with some weird error which was solved by adding type: module to package.json. (ref)

@bobo-k2 bobo-k2 requested review from gluneau and impelcrypto August 24, 2023 12:04
@impelcrypto
Copy link
Member

It seems the type generator (npm run build:types) is not working

=Build from this branch=
image

=Build from the main branch=
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants