This repository has been archived by the owner on Sep 28, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Optimized dapps staking weights by
excluding cached storage item access costs. related: DappsStaking bench improvements #112
executing benchmarking on a baremetal machine whose spec is closest to the substrate reference machine. https://github.com/paritytech/substrate/blob/8a3b2f2e0d4bcf9614dbf174ad2b24da6f9b0b44/frame/balances/src/weights.rs#L20.
Machine spec used
machine bench result
In addition to machine benchmarks to see if machine requirement is met, I did pallet bench for pallet-balances and compare calculated weights with ones in the official substrate repo. This one (
Intel(R) Xeon(R) E-2136 CPU @ 3.30GHz
) is the most closest to it, others are more performant than this one.For more info,
pallet-balances weights
actual in substrate vs tested on
Intel(R) Xeon(R) E-2136 CPU @ 3.30GHz