Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade quasar to the latest version #884

Merged
merged 11 commits into from
Jul 27, 2023
Merged

Upgrade quasar to the latest version #884

merged 11 commits into from
Jul 27, 2023

Conversation

bobo-k2
Copy link
Contributor

@bobo-k2 bobo-k2 commented Jul 26, 2023

Pull Request Summary

I did Quasar version upgrade in effort to resolve critical security issues. Please do sanity check on staging env, also check a browser console

Check list

  • contains breaking changes
  • adds new feature
  • modifies existing feature (bug fix or improvements)
  • relies on other tasks
  • documentation changes
  • tested on mobile devices

@github-actions
Copy link

github-actions bot commented Jul 26, 2023

Visit the preview URL for this PR (updated for commit e4bdfe9):

https://astar-apps--pr884-feat-quasar-upgrade-52nxg6np.web.app

(expires Thu, 03 Aug 2023 07:47:37 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db

@bobo-k2 bobo-k2 marked this pull request as ready for review July 26, 2023 10:34
@impelcrypto
Copy link
Member

impelcrypto commented Jul 26, 2023

It seems something wrong with 'Balance'. It should be more than 0 ASTR

=Localhost=
image

@impelcrypto
Copy link
Member

Getting a mysterious error message on http://localhost:8080/astar/dapp-staking/discover (open the dApp staking page directly, not clicking 'dApp Staking' tab on sidebar)
image

Copy link
Contributor

@gluneau gluneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine for me

@bobo-k2
Copy link
Contributor Author

bobo-k2 commented Jul 26, 2023

@impelcrypto, @gluneau please re-check the PR. I fixed issues.

@gluneau
Copy link
Contributor

gluneau commented Jul 26, 2023

It works. Good to go.

Copy link
Contributor

@Kahonnohak Kahonnohak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@impelcrypto
Copy link
Member

I'm not sure if this is related to this PR, but I saw the empty On-Chain Data sometimes
image

Screenshot 2023-07-26 at 7 04 22 PM

@bobo-k2 bobo-k2 merged commit ed29cec into main Jul 27, 2023
@bobo-k2 bobo-k2 deleted the feat/quasar-upgrade branch July 27, 2023 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants