-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add playwright e2e testing #703
Conversation
Visit the preview URL for this PR (updated for commit 84e7f43): https://astar-apps--pr703-add-playwright-riwh2bre.web.app (expires Thu, 20 Apr 2023 07:12:30 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db |
I completed brief example of test cases in dapp-staking page here , I also want to discuss whether playwright helps while you try to writing e2e testing for the assets page or the dashboard page. @impelcrypto @bobo-k2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
tests-examples/demo-todo-app.spec.ts
Outdated
@@ -0,0 +1,425 @@ | |||
//@ts-ignore | |||
import { test, expect, Page } from '@playwright/test'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this file since tests are not applicable to our use case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can remove it. removed now
Hi @sirius651 |
it seems error says
|
@sirius651 Sorry, it looks like the double quotation ( |
* reafactor: created playwright module * ui-test: added test code for sidebar * refactor: clean up
* Added polkadot wallet * Create polkadot account with Playwright * Additional e2e tests * Moved polkadto wallet to tests folder * Minor refactoring * Headless mode support
merge this PR now, and once the rpc environment is ready, we'll create another PR separately |
Pull Request Summary
Add playwright e2e testing
Check list
Release notes:
add: playwright testing workflow